Fix failing variadic functions when sidecar is enabled#24579
Merged
pdabre12 merged 1 commit intoprestodb:masterfrom Feb 18, 2025
Merged
Fix failing variadic functions when sidecar is enabled#24579pdabre12 merged 1 commit intoprestodb:masterfrom
pdabre12 merged 1 commit intoprestodb:masterfrom
Conversation
Contributor
Author
|
@rschlussel @jaystarshot Can you guys please have a look? Thanks. |
pramodsatya
reviewed
Feb 17, 2025
Contributor
pramodsatya
left a comment
There was a problem hiding this comment.
Thanks @pdabre12, LGTM.
rschlussel
approved these changes
Feb 18, 2025
Contributor
rschlussel
left a comment
There was a problem hiding this comment.
As a follow up, can we run all of native tests with both sidecar enabled and disabled?
Contributor
Author
|
@rschlussel Yes, once support for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where variadic functions were failing when sidecar is enabled.
Motivation and Context
Contributor checklist
Release Notes